fix host and target linker problem #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banditopazzo
changed the title
This was referenced Dec 1, 2022
|
Addressed as part of #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've read all the threads discussing the issue and I've ported the same concepts used in buildroot.
Details
In particular it uses unstable flags to set different linkers for host and target, pointing respectively to
linker-native-wrapper.shandlinker-wrapper.sh.I've removed the linked section generation in the global toml file for consistency with buildroot and also to have linker settings near the unstable flag because part of the them are also unstable.
Without using these flags is impossible to compiler a normal rust application because right now almost all rust applications use dependencies with build scripts inside. These flags also enforce others correct behaviours for cross compilation.
In the end using these flags should be safe, other people have already used them; in case someone complains about that we can always revert the changes and find a better alternative.
Added
Fixed
Closes #97