Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust 1.30.0 #41

Merged
merged 4 commits into from
Nov 13, 2018
Merged

Add Rust 1.30.0 #41

merged 4 commits into from
Nov 13, 2018

Conversation

iohe
Copy link

@iohe iohe commented Nov 7, 2018

Be gentle, still lerning how to do PR.
Add 1.30.0 support

@nastevens
Copy link
Member

Build is currently broken - looks like the COPYRIGHT file upstream changed and our existing implementation is pretty naive: https://github.com/rust-embedded/meta-rust-bin/blob/master/build-new-version.sh#L180. Do you want to try and tackle the changes needed to the script to dynamically write the copyright MD5?

@nastevens nastevens self-requested a review November 7, 2018 14:51
@iohe
Copy link
Author

iohe commented Nov 8, 2018

autocompute md5 for COPYRIGHT file, updated file for rustc and verified that it works.

@nastevens
Copy link
Member

I just found out that Rust 1.30.1 is planned to be released today so we'd be bumping almost immediately. Do you have any objections to waiting for 1.30.1 and then using that?

@iohe
Copy link
Author

iohe commented Nov 8, 2018

Fine with me. As a newbie with github/git and PR, please let me know recommended steps (other than running the script with 1.30.1

@posborne
Copy link
Member

posborne commented Nov 9, 2018

Fine with me. As a newbie with github/git and PR, please let me know recommended steps (other than running the script with 1.30.1

If you have a project using the layer, that would be the other validation to perform. We don't currently have CI setup to automate that as part of this project so @nastevens and I can do that testing as well prior to merge.

@fredszaq
Copy link
Contributor

Hi there!
I've got a fairly big rust project that needs rust 1.30 to compile and it compiled without any problems on an aarch64 target using this branch.
This looks ready to be merged

@posborne
Copy link
Member

@fredszaq Thanks for testing and thanks @iohe for the contribution. Merging.

@posborne posborne merged commit 684839d into rust-embedded:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants