Skip to content
This repository was archived by the owner on Nov 28, 2023. It is now read-only.

use #[no_main] and the entry! macro to specify the main function #9

Merged
merged 1 commit into from
Aug 12, 2018

Conversation

danc86
Copy link
Contributor

@danc86 danc86 commented Aug 10, 2018

@danc86
Copy link
Contributor Author

danc86 commented Aug 10, 2018

This is backwards incompatible for crates which are using riscv-rt (indirectly). I guess we would want to bump the version to 0.2.0.

I will fix up the riscv-rust-quickstart crate soon, I have got a bunch of fixes queued up for it which I am working through.

Also unfortunately it means that the program crates have to depend directly on this crate now, to get the macro. But... 🤷

@dvc94ch
Copy link
Member

dvc94ch commented Aug 10, 2018

LGTM!

Also unfortunately it means that the program crates have to depend directly on this crate now, to get the macro. But... 🤷

Have you tried #![feature(rust_2018_preview)] instead of #[macro_use(entry)] extern crate riscv-rt? [0]

@danc86
Copy link
Contributor Author

danc86 commented Aug 10, 2018

Oooh interesting. I will take a look.

@dvc94ch
Copy link
Member

dvc94ch commented Aug 11, 2018

@danc86 is this ok to merge?

@danc86
Copy link
Contributor Author

danc86 commented Aug 12, 2018

Yep this one is good to go as is. We can always tweak the example to use the rust_2018_preview stuff later on.

@dvc94ch dvc94ch merged commit 41bc210 into rust-embedded:master Aug 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants