Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken book publishing on Travis #24

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Conversation

yerke
Copy link
Contributor

@yerke yerke commented Jul 4, 2020

The books were not published on https://docs.rust-embedded.org/ since March 16 2020. Last successful build here, first broken build here. Here you can see the long list of failures.

I took the changes from https://github.com/rust-embedded/discovery/blob/d42012eedb4216ae8b613c3fdfdb37f85f01656f/ci/install.sh .

For proof that the changes fix the issue see my fork in https://github.com/yerke/docs, which was successfully built with Travis in here. You can see built artifacts at https://github.com/yerke/yerke.github.io/tree/gh-pages and https://yerke.github.io .

Closes #8, rust-embedded/wg#457, rust-embedded/discovery#253

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thejpster (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@yerke
Copy link
Contributor Author

yerke commented Jul 4, 2020

And of course after I spent the whole day chasing this, it turns out that this is the same as #21 :(

@therealprof
Copy link
Contributor

@yerke Not sure I follow. Does this PR fix the problem?

@yerke
Copy link
Contributor Author

yerke commented Jul 4, 2020

It does, yes, @therealprof. You can check https://travis-ci.com/github/yerke/docs/builds/174282136 for successful Travis build and https://yerke.github.io/ as example of built books, as I mentioned in the description.

@therealprof
Copy link
Contributor

Thank you, then let's go with this.

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@yerke
Copy link
Contributor Author

yerke commented Jul 4, 2020

@therealprof Thank you for being so responsive.

@bors
Copy link
Contributor

bors bot commented Jul 4, 2020

Build succeeded:

@bors bors bot merged commit 9ad8d55 into rust-embedded:master Jul 4, 2020
@therealprof
Copy link
Contributor

Thank you for putting time into this. Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reminder: Back out hardcoded mdbook v0.2.1 version
4 participants