Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace try with ? #29

Closed
wants to merge 2 commits into from
Closed

replace try with ? #29

wants to merge 2 commits into from

Conversation

dirvine
Copy link

@dirvine dirvine commented Nov 20, 2016

Now this is available in stable.

@posborne
Copy link
Member

Thanks, I'll probably hold off on merging as I want to continue to support rust versions going back a few for now (especially since 1.13.0 is broken on ARM: rust-lang/rust#37630). I should probably add the oldest supported version to the .travis.yml to codify this design decision.

It's going to take me some time to get used to this new sugar...

We are also going to be moving the devices that are currently in this library out, so it is quite possible that I may have to close this PR when that is done as much of the code will be going away. I'll hold off until that time comes.

@dirvine
Copy link
Author

dirvine commented Nov 20, 2016

No problem at all. I am looking to add some devices, but not sure the current published crate exposes I2CError. This was a 2 min PR so please do feel free to close it, it can be redone later. Beta-2 is Ok for arm atm, prior to that is a security issue AFAIK. Bit of a pain, but I suppose we are moving quickly here :-)

@posborne posborne closed this Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants