Change transfer_multiple to not copy any buffers #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this does change the API, which you can see in my changes to the examples. |
posborne
approved these changes
Oct 27, 2016
|
|
||
| // optional overrides | ||
| pub speed_hz: u32, | ||
| pub delay_usecs: u16, | ||
| pub bits_per_word: u8, | ||
| pub cs_change: u8, | ||
| pub pad: u32, | ||
|
|
||
| tx_buf_ref: PhantomData<&'a [u8]>, | ||
| rx_buf_ref: PhantomData<&'b mut [u8]>, |
There was a problem hiding this comment.
Nice use of PhantomData here. Was concerned about the the transfer outlasting the lifetime of the buffers at first, but this handles that nicely.
|
On the API change, I'll be sure to bump the version in semver appropriately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
SpidevTransferstruct (which is now just an alias forspi_ioc_transfer) to hold references to the tx and rx buffers instead of holding the buffers themselves. This makes it possible to use transfers without copying or heap allocations.