-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added asynchronous pwm functionality #25
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Ryan <ryankurte@users.noreply.github.com>
Cargo.toml
Outdated
@@ -19,3 +20,4 @@ See https://www.kernel.org/doc/Documentation/pwm.txt | |||
readme = "README.md" | |||
|
|||
[dependencies] | |||
tokio = { version = "1", features = ["full"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the full
feature set is an antipattern in libraries per the tokio docs. Could you please reduce this to just the needed features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rust-embedded/embedded-linux I think I'd like to see this published as a separate crate sysfs-pwm-async
. We'd still add the code to this repo, just with its own Cargo.toml. Thoughts?
Putting it in a separate crate seems fine to me since at least the current version does not share anything with the blocking version other than the error type. |
How would I go about doing that? |
Hey sorry for the delay @lucaVuitton, I had planned to make this change but there's been some things in my personal life that are taking priority. If you want to take a try at it, a good place to start would be looking at the structure of the |
No description provided.