Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint const_err has been removed #669

Closed
duskmoon314 opened this issue Oct 13, 2022 · 1 comment
Closed

lint const_err has been removed #669

duskmoon314 opened this issue Oct 13, 2022 · 1 comment

Comments

@duskmoon314
Copy link
Contributor

Currently all generated code have #![deny(const_err)]. This lint has been discussed in rust-lang/rust#71800 and removed in rust-lang/rust#102091. We might need to remove this line shortly.

luojia65 added a commit to luojia65/svd2rust that referenced this issue Oct 15, 2022
This lint has been removed in Rust, see: rust-embedded#669 . We remove it here to avoid compile warnings.
luojia65 added a commit to luojia65/svd2rust that referenced this issue Oct 15, 2022
This lint has been removed in Rust, see: rust-embedded#669 . We remove it here to avoid compile warnings.
luojia65 added a commit to luojia65/svd2rust that referenced this issue Oct 15, 2022
This lint has been removed in Rust, see: rust-embedded#669 . We remove it here to avoid compile warnings.

Signed-off-by: Luo Jia <me@luojia.cc>
Co-authored-by: Emil Gardström <emil.gardstrom@gmail.com>
bors bot added a commit that referenced this issue Oct 15, 2022
672: fix: remove lint #![deny(const_err)] r=burrbull,emilgardis a=luojia65

This lint has been removed in Rust, see: #669 . We remove it here to avoid compile warnings.

Before this pull request, every peripheral access crate this software generates will emit following warning upon compilation:

```
warning: lint `const_err` has been removed: converted into hard error, see issue #71800 <rust-lang/rust#71800> for more information
 --> src\lib.rs:3:9
  |
3 | #![deny(const_err)]
  |         ^^^^^^^^^
  |
  = note: `#[warn(renamed_and_removed_lints)]` on by default
```

Co-authored-by: Luo Jia / Zhouqi Jiang <me@luojia.cc>
@duskmoon314
Copy link
Contributor Author

Close since #672 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant