Add '/', ' ' to BLACKLIST_CHARS
#215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @astro! bors r+ |
bors bot
added a commit
that referenced
this pull request
May 11, 2018
215: Add `'/'`, `' '` to `BLACKLIST_CHARS` r=jamesmunns a=astro These characters occur in [the .svd file for NXP LPC13xx](https://github.com/posborne/cmsis-svd/blob/master/data/NXP/LPC13xx_svd_v1.svd). Co-authored-by: Astro <astro@spaceboyz.net>
Member
|
Looks like Travis tests passed (https://travis-ci.org/japaric/svd2rust/builds/377690793?utm_source=github_status&utm_medium=notification), lets see what our friend bors is waiting on, and I expect to merge this. @astro you may want to consider enabling some of these tests in the CI now that they are not expected to fail. |
Contributor
Timed out |
Member
|
The same thing with timing out happened in #192, something weird is happening with bors |
Member
|
@Emilgardis I think the problem is that bors is waiting for appveyor to pass but appveyor is never running because the appveyor.yaml file was never updated to test the staging and trying branches ... 😅. I'll push a appveyor.yaml fix. Feel free to merge this manually since the tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These characters occur in the .svd file for NXP LPC13xx.