Skip to content

Use and generate code for Edition 2018 only #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

Use and generate code for Edition 2018 only #456

merged 1 commit into from
Jul 28, 2020

Conversation

@therealprof
Copy link
Contributor

@therealprof therealprof commented Jul 27, 2020

No need to maintain extern crate imports anymore

Signed-off-by: Daniel Egger daniel@eggers-club.de

@therealprof
Use and generate code for Edition 2018 only
85615cb 
No need to maintain extern crate imports anymore

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@therealprof therealprof requested a review from a team as a code owner July 27, 2020 23:54
@rust-highfive
Copy link

rust-highfive commented Jul 27, 2020

r? @Emilgardis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 27, 2020
adamgreig
adamgreig approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 28, 2020

Build succeeded:

@bors bors bot merged commit 2cd3630 into master Jul 28, 2020
@bors bors bot deleted the edition-2018 branch July 28, 2020 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@Emilgardis Emilgardis

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@therealprof @rust-highfive @adamgreig @Emilgardis