Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic safe/unsafe W::bits #788

Merged
merged 1 commit into from
Feb 16, 2024
Merged

generic safe/unsafe W::bits #788

merged 1 commit into from
Feb 16, 2024

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Dec 23, 2023 •
edited
Loading

breaking change
mark Writable register with Safety marker.

makes W::bits always unsafe and always present

add safe W::set (other name?) synonym for W::bits.

@burrbull burrbull requested a review from a team as a code owner December 23, 2023 06:46
@burrbull burrbull marked this pull request as draft December 23, 2023 07:29
@burrbull burrbull force-pushed the bits branch 3 times, most recently from 76ff6fe to 39d99be Compare December 25, 2023 12:52
@burrbull
Copy link
Member Author

cc @rust-embedded/tools what do you think?

@Emilgardis
Copy link
Member

/ci diff pr

@github-actions GitHub Actions
Copy link

Diff for comment

@burrbull burrbull force-pushed the bits branch 3 times, most recently from dfc8e26 to 47408fc Compare January 13, 2024 07:55
@burrbull burrbull marked this pull request as ready for review January 23, 2024 20:32
@burrbull
Copy link
Member Author

@Emilgardis let's merge this.

@Emilgardis Emilgardis added this pull request to the merge queue Feb 16, 2024
Merged via the queue into master with commit fe1e230 Feb 16, 2024
46 checks passed
@Emilgardis Emilgardis deleted the bits branch February 16, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @Emilgardis