regress improvements #806
Merged
regress improvements #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
force-pushed
the
regress-improvements
branch
from
6ab2037 to
a718ec8
Compare
Member
Author
|
keeping delta would be nice, it provides much better context in the headers , maybe just disabling colors would be enough |
Emilgardis
force-pushed
the
regress-improvements
branch
from
282f58c to
d8523c7
Compare
Emilgardis
commented
Feb 3, 2024
Comment on lines
+78
to
+82
| # workaround for https://github.com/rust-lang/cargo/pull/12779, doesn't work for output though | ||
| # see https://github.com/rust-lang/cargo/issues/6009#issuecomment-1925445245 | ||
| "output/baseline/**", | ||
| "output/current/**" | ||
| ] |
Member
Author
There was a problem hiding this comment.
this actually doesnt work, at all, it looked like it did work but then it started failing again. rust-lang/cargo#6009 (comment)
either we need to have this be fixed, or we initialize in a temporary folder then move that folder
Comment on lines
60
to
66
| GITHUB_PR: ${{ matrix.pr }} | ||
| GIT_PAGER: delta --hunk-header-style omit | ||
| summary: |
Member
Author
There was a problem hiding this comment.
I think we can use --raw for this to keep the context delta provides but get rid of the faulty coloring github actions does
``` cargo regress test -a cortex-m --url https://raw.githubusercontent.com/cmsis-svd/cmsis-svd/9c416c5ff18e7d272a792c13bd235ebe30eef816/data/ARM_SAMPLE/CMSDK_CM3.svd ```
Emilgardis
force-pushed
the
regress-improvements
branch
from
d8523c7 to
57f6bbe
Compare
burrbull
approved these changes
Feb 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.