Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.35.0 #887

Merged
merged 1 commit into from
Nov 13, 2024
Merged

release 0.35.0 #887

merged 1 commit into from
Nov 13, 2024

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull requested a review from a team as a code owner November 12, 2024 13:51
@jessebraham
Copy link
Member

jessebraham commented Nov 12, 2024

#886 contains breaking changes.

error[E0308]: mismatched types
   --> xtask/src/main.rs:222:31
    |
222 |             config.settings = Some(settings);
    |             ---------------   ^^^^^^^^^^^^^^ expected `Settings`, found `Option<PathBuf>`
    |             |
    |             expected due to the type of this binding
    |
    = note: expected struct `Settings`
                 found enum `Option<PathBuf>`

For more information about this error, try `rustc --explain E0308`.

@burrbull
Copy link
Member Author

changed to 0.35.0

@burrbull
Copy link
Member Author

222 | config.settings = Some(settings);

renamed to settings_file

@burrbull burrbull added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit b6ef0b0 Nov 13, 2024
46 checks passed
@burrbull burrbull deleted the r0341 branch November 13, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants