Skip to content

Update Embedded Book for mdbook 0.2.0 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Havvy
Copy link

@Havvy Havvy commented Aug 18, 2018

mdbook 0.2.0's has a breaking change such that links are relative to the file they are in instead of the top level of the book. Luckily, this is your only link like that. So once you accept this PR you can build with mdbook 0.2.0 which is what we're trying to switch to for the the bookshelf.

mdbook 0.2.0's has a breaking change such that links are relative to the file they are in instead of the top level of the book. Luckily, this is your only link like that. So once you accept this PR you can build with mdbook 0.2.0 which is what we're trying to switch to for the the bookshelf.
@Havvy Havvy requested review from dylanmckay, jcsoo and a team as code owners August 18, 2018 23:12
@Havvy Havvy mentioned this pull request Aug 18, 2018
10 tasks
@hannobraun
Copy link
Member

cc @rust-embedded/resources

@jamesmunns
Copy link
Member

Sorry for the delay, I'm still in the US running around after RustFest. I should hopefully have some time this week to review and address this. Thanks for the contribution @Havvy!

@japaric
Copy link
Member

japaric commented Aug 20, 2018

Thanks for the PR, @Havvy. The book was moved into its own repository (see https://github.com/rust-embedded/book) just a while ago but we forgot the remove the old version from this repository. Sorry for the confusion.

Also, the problem with mdbook 0.2 and links has already been fixed in rust-embedded/book#13.

@japaric japaric closed this Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants