Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore signature when parsing function names #28

Merged
merged 4 commits into from
Jun 15, 2017

Conversation

andresilva
Copy link
Contributor

Fixes #10.

@andresilva andresilva force-pushed the fix-function-name-parsing branch 2 times, most recently from e4ff65e to 7b4a4f5 Compare June 13, 2017 22:45
f.name.truncate(i);
}
Operation::Function(f)
}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about event and fallback? Shouldn't we also truncate their names?

cc @tomusdrw

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, IMHO we should do it for events as well. Not sure about fallback though, in this functions seems that it's already parsed.

@andrebeat Could you add some more tests for fallback (name: "" and name: "()") and events?

Copy link
Contributor Author

@andresilva andresilva Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback function is currently ignored (also according to the spec it doesn't have a name). I just added the same changes for events and added more tests. 👍

@andresilva andresilva force-pushed the fix-function-name-parsing branch from 7b4a4f5 to 950962f Compare June 14, 2017 22:29
@debris debris merged commit aa53c63 into rust-ethereum:master Jun 15, 2017
@debris
Copy link
Collaborator

debris commented Jun 15, 2017

thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants