Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes/improvements for no_std builds #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eranrund
Copy link

  1. Build serde_json without the std feature when it is not enabled in this crate
  2. Provide Display implementation for the Error enum in no_std builds

Some context for this: I am trying to get https://github.com/gakonst/ethers-rs/ (specifically the ethers-core) crate to work in a no_std build. ethabi is a dependency of it, and while iterating on it I ran into the issues this PR addresses.

Thank you!

1. Build serde_json without the `std` feature when it is not enabled in
   this crate
2. Provide `Display` implementation for the `Error` enum in `no_std`
   builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant