Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy pass fails #245

Closed
Tracked by #246
mrLSD opened this issue Nov 30, 2023 · 1 comment
Closed
Tracked by #246

Clippy pass fails #245

mrLSD opened this issue Nov 30, 2023 · 1 comment

Comments

@mrLSD
Copy link
Contributor

mrLSD commented Nov 30, 2023

Description

For the current master branch clippy with basic configurations fails:

cargo clippy --workspace -- -D warnings

⏩ Proposal

Fix basic clippy issues and add basic clippy rules to CI:

cargo clippy --workspace -- -D warnings
cargo clippy --workspace --no-default-features -- -D warnings
cargo clippy --workspace --features=with-codec,with-serde -- -D warnings

📓 NOTES

There are a lot of issues when enabling:

cargo clippy --workspace -- -D warnings -D clippy::pedantic -D -D clipyy::nursery

Enabling these clippy flags 🎏 is out of the current proposal.
mrLSD added a commit to aurora-is-near/sputnikvm that referenced this issue Nov 30, 2023
@mrLSD
Extend clippy - rust-ethereum#245
0d62095
@mrLSD mrLSD mentioned this issue Nov 30, 2023
Merged
2 tasks
sorpaas pushed a commit that referenced this issue Nov 30, 2023
@mrLSD
Feat: add basic clippy (#246)
53d082f 
* Fix no-std dependencies to fix #243

* Add basic clippy level

* Extend clippy - #245

* Extend clippy

* Changed  use to alloca #243

* Remove lifetime

* Simplify  for code consistency. Extend CI

* Partly remove lifetime

* Remove resolver-lifetime, and remove CI repeat-checkout

* Restore CI checkout for tests
@mrLSD
Copy link
Contributor Author

mrLSD commented Nov 30, 2023

Fixed in #246

@mrLSD mrLSD closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrLSD