fix: double substate discard in eip-3860 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
reviewed
Mar 28, 2023
joshuajbouw
approved these changes
Mar 28, 2023
sorpaas
approved these changes
Mar 28, 2023
zjb0807
added a commit
to AcalaNetwork/Acala
that referenced
this pull request
Jan 22, 2024
zjb0807
added a commit
to AcalaNetwork/Acala
that referenced
this pull request
Jan 29, 2024
* update PrecompileHandle ref: rust-ethereum/evm#122 * update fee calculation ref: rust-ethereum/evm#132 * add code_size/code_hash fn in StackState trait ref: rust-ethereum/evm#140 * update evm call stack ref: rust-ethereum/evm#136 * update evm call stack ref: rust-ethereum/evm#155 * add shanghai eips 3651, 3855, 3860 ref: rust-ethereum/evm#152 * update is_precompile ref: rust-ethereum/evm#157 * fix eip-3860 ref: rust-ethereum/evm#160 * update runtime config ref: rust-ethereum/evm#161 * add eip-4399 ref: rust-ethereum/evm#162 * fix eip-2618 ref: rust-ethereum/evm#163 * fix nonce back to U256 ref: rust-ethereum/evm#166 * remove exit_substate in create functions ref: rust-ethereum/evm#168 * record external cost ref: rust-ethereum/evm#170 * add record_external_operation ref: rust-ethereum/evm#171 * add storage_growth ref: rust-ethereum/evm#173 * update evm * switch to shanghai hardfork * update ecrecover ref: polkadot-evm/frontier#964 (#2696)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OutOfGaserror code used for initcode limit violations has been changed toCreateContractLimit, and superfluousInitCodeLimiterror was removed.Details
More detail about the bug
The problem was that the current execution's memory stack substate was discarded immediately in the error path:
https://github.com/rust-blockchain/evm/blob/2e9c3b71f7b9ff241735f15145517d0627c469e6/src/executor/stack/executor.rs#L402-L409
while the
transact_{call,create}methods also attempted to exit the same substate in their cleanup procedures:https://github.com/rust-blockchain/evm/blob/2e9c3b71f7b9ff241735f15145517d0627c469e6/src/executor/stack/executor.rs#L346-L355
E.g.,
cleanup_for_callcallsexit_substatehere: https://github.com/rust-blockchain/evm/blob/2e9c3b71f7b9ff241735f15145517d0627c469e6/src/executor/stack/executor.rs#L989However, because such a substate no longer existed at that point and only the root substate remained, the executor would panic as the root substate cannot be removed.
Context - the test case that triggered the bug
The way this error surfaced was when the initial
StackExecutor::transact_{call,create}executed code that contained aCREATE/2opcode which resulted in a call to<StackExecutor as Handler>::create.Specifically, the
st_randomandst_random2tests were failing, e.g. therandomStatetest307test case contained code what would try to create a contract with an initcode size of 50k bytes that exceeded the initcode size limit and thus triggered the error path in the nested create call (CREATEopcode).