Berlin support #40
Merged
Berlin support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d7ea767.
4 tasks
1 task
|
Can you merge master and do rustfmt again? Thank you! |
sorpaas
reviewed
Jul 29, 2021
sorpaas
reviewed
Jul 29, 2021
sorpaas
reviewed
Jul 29, 2021
src/executor/stack/mod.rs
Outdated
|
|
||
| /// Stack-based executor. | ||
| pub struct StackExecutor<'config, S> { | ||
| pub struct StackExecutor<'config, S: StackState<'config>, P: Precompiles<S>> { |
There was a problem hiding this comment.
What's the rationale for this change? One of the drawback of this is that it'll be potentially difficult for users to get a single type for StackExecutor suitable for different configurations of precompiles. Same reason why Config is not a generic parameter.
There was a problem hiding this comment.
That might've been an overzealous mistake there. I'll double check.
sorpaas
reviewed
Jul 29, 2021
joshuajbouw
force-pushed
the
berlin-support
branch
from
2b60e2d to
7da1cbd
Compare
Co-authored-by: Wei Tang <accounts@that.world>
joshuajbouw
force-pushed
the
berlin-support
branch
from
7da1cbd to
d16bdec
Compare
sorpaas
reviewed
Aug 2, 2021
sorpaas
reviewed
Aug 4, 2021
joshuajbouw
force-pushed
the
berlin-support
branch
from
051ec20 to
a252024
Compare
|
Updated our nightly and we are getting benefits of reduced compile size and speed. So, going to keep it in. |
sorpaas
reviewed
Aug 20, 2021
| impl<'config, S: StackState<'config>> StackExecutor<'config, S> { | ||
| /// Create a new stack-based executor. | ||
| pub fn new(state: S, config: &'config Config) -> Self { |
sorpaas
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds both EIP-2929 and EIP-2930 into the EVM.
This is a key PR as it brings the necessary changes to get Berlin hard fork working with the EVM. Since this is a critical update, a discussion and review will be very welcomed. Do note that we will also be updating evm-tests as well to ensure full compatibility with Ethereum VM.
Others related to Berlin, EIP-2565 and EIP-2718, should be done on libraries implementing this change.