refactor(foreign): move implementations to dedicated, structured directory #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the trait-definition and all implementations for foreign types are located in
lib.rs
with 1732 LOC. IMHO this is difficult to maintain, especially when adding additional implementations. By moving all implementations into the private submoduleforeign
, sorting them bycore
,alloc
andstd
and submodules similar to those documented in e.g. https://doc.rust-lang.org/std/, I see i.a. the following advantages:core
/alloc
/std
and does not have to guess, whether to place it at the beginning or end oflib.rs
or somewhere random,std
forstd
-implementations, which should be a default-feature, which can be disabled forno_std
-builds,chrono
ortime
, can be placed inforeign
behind feature-gates,However, this is indeed quite a large change and will require additional PRs e.g. for feature-gating, fixing the usage of
std
inalloc
, adding missing implementations, ….