fix(derive): allow derive(Arbitrary) for struct Option
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this needs a |
Use the full path to `core::option::Option` and `core::default::Default` in the generated code. This allows `derive(Arbitrary)` on structs named `Option` or `Default`.
caspermeijn
force-pushed
the
derive_option
branch
from
b18ed3d to
aa899f9
Compare
Oops. I didn't run that locally, but fortunately CI caught it :-) |
|
@fitzgen I would like to see this feature released. Can I help you to prepare for a release? |
|
I've been on vacation, will cut a release today, or maybe tomorrow at the latest. |
|
Published 1.4.0, sorry for the delay |
|
Thank you for the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the full path to
core::option::Optionandcore::default::Defaultin the generated code. This allowsderive(Arbitrary)on structs namedOptionorDefault.This allows me to derive Arbitrary on
prost_types::Option.