Require exact version of arbitrary-derive
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally I'd prefer a |
`Arbitrary` had a new `try_size_hint` method added in rust-fuzz#185 - while this was semver safe for `arbitrary` because a default implementation was provided which forwarded along, the new version of `arbitrary-derive` which follows the same versioning as `arbitrary` started generating `try_size_hint` methods, which causes v1.2.3 to fail to compile, as it tries to grab `arbitrary-derive` "1.2.3" from crates.io, which gets responded to with a "1.4.0" version. Given that: 1. It is reasonable to evolve your traits this way, and it doesn't break semver on the base package 2. The patchlevel is specified on `arbitrary-derive`, so it seems the intent is to require a matching version 3. You likely want to keep the same version for your proc-macro as your main crate This proposes using exact equality in the `Cargo.toml` so that future trait updates of this nature won't break the ability to build older packages via Cargo.
|
SGTM, switched to "~1.4.0" This won't fix the old versions, but will mean that similar situations ( |
Manishearth
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arbitraryhad a newtry_size_hintmethod added in #185 - while this was semver safe forarbitrarybecause a default implementation was provided which forwarded along, the new version ofarbitrary-derivewhich follows the same versioning asarbitrarystarted generatingtry_size_hintmethods, which causes v1.2.3 to fail to compile, as it tries to grabarbitrary-derive"1.2.3" from crates.io, which gets responded to with a "1.4.0" version. This means thatarbitrary-derivetechnically has a semver break from 1.2.3 to 1.4.Given that:
arbitrary-derive, so it seems the intent is to require a matching versionThis proposes using exact equality in the
Cargo.tomlso that future trait updates of this nature won't break the ability to build older packages via Cargo.