Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Unstructured::choose param should return Err, not panic. #71

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Feb 6, 2021

Addressing @fitzgen's comment: #62 (comment)

I chose to return an Err instead of Result<Option<T>> since that's an extra layer of clunk. Thoughts?

@frewsxcv frewsxcv merged commit a088f82 into staging-1.0 Feb 7, 2021
@frewsxcv frewsxcv deleted the frewsxcv-choose branch February 7, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants