Support custom hashers for HashMap/-Set #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Aug 25, 2021
|
Thanks! |
|
Is there any chance of you releasing a version with this change in it in the next couple of days, or should I make a PR with a version bump or something similar? |
|
We also need to make a changelog; but if you can make a PR with an updated changelog and version bump that would speed stuff up for me! |
Sure, if that helps I'll write something up and create a PR with it ^^. Edit: Done, see #88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naga uses a custom hasher for a
HashMapof defines for a GLSL parser. Allowing for the use of custom hashers with arbitrary would simplify adding fuzzing support for the GLSL parser.