-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stars and last commit for crates and various git hosts #590
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good! 👍
I need to give some thought to how this would interact with #589 before I merge, though - the approach I've taken on that PR won't work for the crates
source as is, so if I go forward with this functionality, I'll need to rethink that a little bit.
I have incorporated the functionality of this PR into #591 - though it currently only works for GitHub and GitLab, as I haven't investigated the Gitea API yet. Please take a look 🙂 |
No problem, to make it easier, I found the Gitea API docs that should contain all that data that will be required here: https://docs.gitea.com/api/1.20/#tag/repository/operation/repoGet |
Gitea support is now working on the other branch 👍 I did find while trying to test that there aren't any crates that have Gitea URLs at the moment, though 😄 |
Only reason I added Gitea was that it was available on Shields.io . I just preparing for it just in case since Gitea is popular enough to part of Shields.io |
No description provided.