Skip to content

N34: Add Fyrox #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2022
Merged

N34: Add Fyrox #1051

merged 2 commits into from
Jun 5, 2022

Conversation

mrDIMAS
Copy link
Contributor

@mrDIMAS mrDIMAS commented May 31, 2022

Part of #1033

17cupsofcoffee
17cupsofcoffee reviewed Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide says to only use one bulleted list per section, but I think given this is covering two seperate updates, it should be okay? cc @ozkriff for a second opinion

@ozkriff ozkriff changed the title Add Fyrox N34: Add Fyrox Jun 5, 2022
ozkriff
ozkriff approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i guess a small exception in this case is ok 🤔

@ozkriff ozkriff merged commit 3f75f11 into rust-gamedev:source Jun 5, 2022
@ozkriff
Copy link
Member

ozkriff commented Jun 5, 2022

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee left review comments

@ozkriff ozkriff ozkriff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrDIMAS @ozkriff @17cupsofcoffee