-
Notifications
You must be signed in to change notification settings - Fork 343
N43: Cootsmania #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N43: Cootsmania #1291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we could reduce the cootsmania.png
image size, then it should be good :) Maybe switch both to jpgs?
@kuviman out of curiosity, might it be interesting to add a section on |
switched both to jpg and rescaled the first one to 50% size talking about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid that out style guide allows only one image:
Only include one image (<300kb) or GIF (<2.5mb).
- Images should be placed before text, with an optional caption and mandatory alternate text for accessibility.
- Unless essential to demonstrating your project, prefer static images over GIFs, to keep the file size down.
Otherwise LGTM
@kuviman yeah, we're definitely interested in a PR with geng updates section! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 (removed one image and made a couple of style tweaks after the discussion in Telegram )
Thanks for the PR, Vitaliy! |
Part of #1287