Skip to content

N43: Cootsmania #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2023
Merged

N43: Cootsmania #1291

merged 3 commits into from
Mar 4, 2023

Conversation

kuviman
Copy link
Contributor

@kuviman kuviman commented Mar 2, 2023

Part of #1287

Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could reduce the cootsmania.png image size, then it should be good :) Maybe switch both to jpgs?

@AngelOnFira
Copy link
Member

@kuviman out of curiosity, might it be interesting to add a section on geng as well?

@kuviman
Copy link
Contributor Author

kuviman commented Mar 2, 2023

switched both to jpg and rescaled the first one to 50% size

talking about geng, im not trying to make other people use it, but if you're interested I can write a small section - there were sound & font related updates in february

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that out style guide allows only one image:

Only include one image (<300kb) or GIF (<2.5mb).

  • Images should be placed before text, with an optional caption and mandatory alternate text for accessibility.
  • Unless essential to demonstrating your project, prefer static images over GIFs, to keep the file size down.

Otherwise LGTM

@ozkriff
Copy link
Member

ozkriff commented Mar 4, 2023

talking about geng, im not trying to make other people use it, but if you're interested I can write a small section - there were sound & font related updates in february

@kuviman yeah, we're definitely interested in a PR with geng updates section!

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (removed one image and made a couple of style tweaks after the discussion in Telegram )

@ozkriff ozkriff merged commit 67a12ed into rust-gamedev:source Mar 4, 2023
@ozkriff
Copy link
Member

ozkriff commented Mar 4, 2023

Thanks for the PR, Vitaliy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants