Skip to content

Release N51 #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 5, 2024
Merged

Release N51 #1521

merged 15 commits into from
Jun 5, 2024

Conversation

janhohenheim
Copy link
Collaborator

@janhohenheim janhohenheim commented Jun 3, 2024 •
edited
Loading

Resolves #1505

Rendered

Depends on #1520. The link-checking CI step will fail until it is merged first.

@janhohenheim janhohenheim marked this pull request as ready for review June 3, 2024 06:47
ThierryBerger
ThierryBerger reviewed Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@ThierryBerger ThierryBerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

AngelOnFira
AngelOnFira requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one item for now, I'll try to do a pass on it later myself :)

@janhohenheim janhohenheim requested a review from AngelOnFira June 3, 2024 22:36
janhohenheim and others added 2 commits June 4, 2024 00:45
@janhohenheim
React to feedback
6bb07a7
@AngelOnFira @janhohenheim
Small release fixes (#1524)
71c6401 
Co-authored-by: Jan Hohenheim <jan@hohenheim.ch>
AngelOnFira
AngelOnFira approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to update the date :)

@janhohenheim janhohenheim merged commit 4823ef7 into source Jun 5, 2024
@janhohenheim janhohenheim deleted the release-51 branch June 5, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThierryBerger ThierryBerger ThierryBerger left review comments

@AngelOnFira AngelOnFira AngelOnFira approved these changes

@erlend-sh erlend-sh Awaiting requested review from erlend-sh

@17cupsofcoffee 17cupsofcoffee Awaiting requested review from 17cupsofcoffee

@mamaicode mamaicode Awaiting requested review from mamaicode

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Newsletter 51: May 2024

3 participants

@janhohenheim @ThierryBerger @AngelOnFira