Skip to content

Newsletter 13: Add blitz-path #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 4, 2020

Conversation

BezPowell
Copy link
Contributor

Part of #232

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, just needs breaking onto more lines to satisfy the formatting CI checks:

BezPowell and others added 2 commits August 30, 2020 09:29
Following 17cupsofcoffee's suggestion.

Co-authored-by: Joe Clay <27cupsofcoffee@gmail.com>
Co-authored-by: Joe Clay <27cupsofcoffee@gmail.com>
@BezPowell
Copy link
Contributor Author

Content looks good, just needs breaking onto more lines to satisfy the formatting CI checks:

Thanks for the suggestions, I have applied them now. Does the url of links get taken into account for the line-length?

@17cupsofcoffee
Copy link
Collaborator

They shouldn't do, I think it was a false positive because of there being trailing whitespace after the link.

Co-authored-by: Joe Clay <27cupsofcoffee@gmail.com>
@BezPowell
Copy link
Contributor Author

I'm terribly sorry, I seem to be making a lot of unnecessary work for you. I ran it through a linter provided by a VSCode extension originally and as it didn't complain assumed it was ok, it looks like it actually didn't report any errors because it wasn't working 😆

@17cupsofcoffee
Copy link
Collaborator

It's no problem at all, I don't know of an easy way of running the lint config locally so I also make mistakes in my own PRs 😅

@ozkriff ozkriff changed the title Add blitz-path august content Newsletter 13: Add blitz-path Sep 2, 2020
@ozkriff ozkriff mentioned this pull request Sep 2, 2020
53 tasks
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozkriff ozkriff merged commit b7e8430 into rust-gamedev:source Sep 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Sep 4, 2020

Thanks for the PR!

It's no problem at all, I don't know of an easy way of running the lint config locally so I also make mistakes in my own PRs

@17cupsofcoffee I'm using https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint vscode extension to auto-run all the lints with our config file locally. I guess this (along with a style/formatting guide) should be documented in CONTRIBUTING.md or something.. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants