-
Notifications
You must be signed in to change notification settings - Fork 343
Newsletter 13: Add blitz-path #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good, just needs breaking onto more lines to satisfy the formatting CI checks:
Following 17cupsofcoffee's suggestion. Co-authored-by: Joe Clay <27cupsofcoffee@gmail.com>
Co-authored-by: Joe Clay <27cupsofcoffee@gmail.com>
Thanks for the suggestions, I have applied them now. Does the url of links get taken into account for the line-length? |
They shouldn't do, I think it was a false positive because of there being trailing whitespace after the link. |
Co-authored-by: Joe Clay <27cupsofcoffee@gmail.com>
I'm terribly sorry, I seem to be making a lot of unnecessary work for you. I ran it through a linter provided by a VSCode extension originally and as it didn't complain assumed it was ok, it looks like it actually didn't report any errors because it wasn't working 😆 |
It's no problem at all, I don't know of an easy way of running the lint config locally so I also make mistakes in my own PRs 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for the PR!
@17cupsofcoffee I'm using https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint vscode extension to auto-run all the lints with our config file locally. I guess this (along with a style/formatting guide) should be documented in CONTRIBUTING.md or something.. 🤔 |
Part of #232