Skip to content

Newsletter 13: Add a section about puffin profiler #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2020
Merged

Newsletter 13: Add a section about puffin profiler #244

merged 3 commits into from
Sep 4, 2020

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Aug 31, 2020

17cupsofcoffee
17cupsofcoffee approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a very minor tweak to the phrasing of the opening paragraph, but otherwise this looks good.

@ozkriff ozkriff mentioned this pull request Sep 2, 2020
Closed
53 tasks
@ozkriff
Copy link
Member

ozkriff commented Sep 4, 2020

@emilk could you either resolve the conflicts or enable the "allow edits from maintainers." checkbox, please?

@emilk
Copy link
Contributor Author

emilk commented Sep 4, 2020 •
edited
Loading

@emilk could you either resolve the conflicts or enable the "allow edits from maintainers." checkbox, please?

Conflicts resolved, but out of curiosity: where is that checkbox you speak of? I see it not.

@ozkriff ozkriff merged commit c9b2687 into rust-gamedev:source Sep 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Sep 4, 2020

Merged, thanks!

where is that checkbox you speak of? I see it not.

Should be in the right panel:

image

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@emilk
Copy link
Contributor Author

emilk commented Sep 4, 2020

It's not there for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilk @ozkriff @17cupsofcoffee