Skip to content

Newsletter 13: SIMple Physics #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 6, 2020
Merged

Newsletter 13: SIMple Physics #257

merged 8 commits into from
Sep 6, 2020

Conversation

mkhan45
Copy link
Contributor

@mkhan45 mkhan45 commented Sep 3, 2020

For #232

17cupsofcoffee
17cupsofcoffee approved these changes Sep 3, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me, just missing one bit of markup on the discussions.

It might also be a little nicer to phrase the project/gifs/github links as a sentence, rather than having them broken over three lines?

mkhan45 and others added 2 commits September 3, 2020 16:35
@mkhan45 @17cupsofcoffee
Update content/posts/newsletter-013/index.md
e5e665f 
fix italics markup

Co-authored-by: Joe Clay <27cupsofcoffee@gmail.com>
@mkhan45
moved linkes into one sentence
8844734
@mkhan45
Copy link
Contributor Author

mkhan45 commented Sep 3, 2020

It might also be a little nicer to phrase the project/gifs/github links as a sentence, rather than having them broken over three lines?

I agree; I think it's better now

@ozkriff ozkriff mentioned this pull request Sep 5, 2020
Closed
53 tasks
ozkriff
ozkriff approved these changes Sep 6, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (made a few style/fmt tweaks, added "Requests for Contribution" list item, and optimized the gif a little)

@ozkriff ozkriff merged commit 2243458 into rust-gamedev:source Sep 6, 2020
@ozkriff
Copy link
Member

ozkriff commented Sep 6, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkhan45 @ozkriff @17cupsofcoffee