Skip to content

Conversation

ecton
Copy link
Contributor

@ecton ecton commented Sep 3, 2020

Part of #232

One of my links is longer than the softwrap limit, let me know if that's an issue! Thank you for letting me contribute!

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your content looks good, but some of the links are broken - to use the footnote-style links, the ID needs to be in square brackets, not parentheses. e.g. [Kludgine](kludgine) should be [Kludgine][kludgine].

You use parentheses when you're placing the URL inline - so for example, [Chillscapes](https://khonsulabs.itch.io/chillscapes) is fine and will work :)

The link going past the line length limit is fine, there's no way to break that over multiple lines and it's not tripping up the lint CI job.

@ecton ecton requested a review from 17cupsofcoffee September 3, 2020 20:17
@ecton
Copy link
Contributor Author

ecton commented Sep 3, 2020

Sorry about that, first time I used the footnote link syntax, and I didn't notice the nuance. Of course, I also didn't test all of the links in the preview.... and more importantly the one I tested was the one that wasn't converted lol

All the links should be fixed and working now. Thank you!

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 All looks good now!

@ozkriff ozkriff merged commit 037b896 into rust-gamedev:source Sep 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Sep 4, 2020

Merged, thanks for the PR!

@ozkriff ozkriff mentioned this pull request Sep 4, 2020
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants