Newsletter 13: Bevy Engine #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good for the most part! Only nitpicks:
- To keep it from being super long, we don't usually add the individual sections to the TOC
- Generally I think it's preferred to write the updates in third person ('they' rather than 'we'), just to keep a consistent tone throughout the newsletter
- There's a few things tripping up the linter (mostly just line lengths and list style):
content/posts/newsletter-013/index.md:74:81 MD013/line-length Line length [Expected: 80; Actual: 121]
content/posts/newsletter-013/index.md:76:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:77:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:78:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:78:81 MD013/line-length Line length [Expected: 80; Actual: 89]
content/posts/newsletter-013/index.md:79:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:80:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:81:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:85:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:86:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:86:81 MD013/line-length Line length [Expected: 80; Actual: 111]
content/posts/newsletter-013/index.md:87:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:87:81 MD013/line-length Line length [Expected: 80; Actual: 191]
content/posts/newsletter-013/index.md:88:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:88:81 MD013/line-length Line length [Expected: 80; Actual: 160]
content/posts/newsletter-013/index.md:89:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:89:211 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
content/posts/newsletter-013/index.md:89:81 MD013/line-length Line length [Expected: 80; Actual: 211]
content/posts/newsletter-013/index.md:90:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-013/index.md:90:243 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
content/posts/newsletter-013/index.md:90:81 MD013/line-length Line length [Expected: 80; Actual: 243]
17cupsofcoffee
approved these changes
Sep 3, 2020
ozkriff
approved these changes
Sep 7, 2020
|
Merged, thanks for the PR! Good luck with this epic endeavor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #232