Skip to content

N14: Riddle #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2020
Merged

N14: Riddle #284

merged 4 commits into from
Oct 4, 2020

Conversation

vickles
Copy link
Contributor

@vickles vickles commented Oct 2, 2020

Related to: #278

@vickles vickles changed the title Riddle section of newsletter #14 N14: Riddle Oct 2, 2020
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me, but I think the preferred style is to link to things like GitHub and docs within the text itself rather than having a link dump at the end. Might be worth making the title and the first word of the section link to the Github and work the docs link into the text?

The one exception to that is discussion threads, which are usually formatted like this at the end of the section:

_Discussions: [/r/rust](https://reddit.com/r/rust/todo), [twitter](https://twitter.com/todo/status/123456)_

See the template for more context: https://raw.githubusercontent.com/rust-gamedev/rust-gamedev.github.io/source/newsletter-template.md

@vickles
Copy link
Contributor Author

vickles commented Oct 2, 2020

I've removed the link dump and placed them in the body of the post as suggested

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect, thank you!

@ozkriff ozkriff mentioned this pull request Oct 3, 2020
49 tasks
@ozkriff ozkriff merged commit a602910 into rust-gamedev:source Oct 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Oct 4, 2020

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants