Skip to content

N14: add rg3d and rusty-editor #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 5, 2020
Merged

N14: add rg3d and rusty-editor #288

merged 23 commits into from
Oct 5, 2020

Conversation

mrDIMAS
Copy link
Contributor

@mrDIMAS mrDIMAS commented Oct 2, 2020 •
edited by ozkriff
Loading

Part of #278 ("Newsletter 14")

17cupsofcoffee
17cupsofcoffee requested changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good! I don't think there's a ton of value in having the ### [rg3d][rg3d] and [rusty-editor][rusty editor] heading, though. Could you remove that and make the two other headings a level higher?

@mrDIMAS mrDIMAS requested a review from 17cupsofcoffee October 2, 2020 21:03
17cupsofcoffee
17cupsofcoffee approved these changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes, approving :)

@ozkriff ozkriff mentioned this pull request Oct 4, 2020
Closed
49 tasks
@ozkriff ozkriff changed the title add rg3d and rusty-editor N14: add rg3d and rusty-editor Oct 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Oct 4, 2020

@mrDIMAS 🤔 It'd be cool to add an image or a gif to the rg3d section. My first thought is to convert https://twitter.com/DmitryS36934349/status/1239923629883875328 into a gif

ozkriff
ozkriff approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (optimized images a bit, made a few style tweaks for consistency)

@ozkriff ozkriff merged commit d2f5464 into rust-gamedev:source Oct 5, 2020
@ozkriff
Copy link
Member

ozkriff commented Oct 5, 2020

Merged, thanks for the PR! :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrDIMAS @ozkriff @17cupsofcoffee