Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N15: Wilds #340

Merged
merged 5 commits into from
Nov 4, 2020
Merged

N15: Wilds #340

merged 5 commits into from
Nov 4, 2020

Conversation

zakarumych
Copy link
Contributor

@zakarumych zakarumych commented Nov 4, 2020

Part of #320 ("Newsletter 15")

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good 👍 Just needs some style fixes to pass the CI check:

content/posts/newsletter-015/index.md:345:81 MD013/line-length Line length [Expected: 80; Actual: 115]
content/posts/newsletter-015/index.md:347:81 MD013/line-length Line length [Expected: 80; Actual: 107]
content/posts/newsletter-015/index.md:348:81 MD013/line-length Line length [Expected: 80; Actual: 95]
content/posts/newsletter-015/index.md:355:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-015/index.md:355:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
content/posts/newsletter-015/index.md:355 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "* [~~Shave more yaks~~]"]
content/posts/newsletter-015/index.md:356:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-015/index.md:356:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
content/posts/newsletter-015/index.md:357:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-015/index.md:357:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
content/posts/newsletter-015/index.md:358:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-015/index.md:358:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
content/posts/newsletter-015/index.md:359:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-015/index.md:359:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
content/posts/newsletter-015/index.md:360:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-015/index.md:360:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
content/posts/newsletter-015/index.md:361:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-015/index.md:361:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
content/posts/newsletter-015/index.md:362:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-015/index.md:362:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]
content/posts/newsletter-015/index.md:363:1 MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]
content/posts/newsletter-015/index.md:363:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 2]

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakarumych Could you shorten the future plans list, please?

@ozkriff ozkriff mentioned this pull request Nov 4, 2020
54 tasks
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks good now, so approving to unblock the merge (subject to ozkriff's stuff being resolved).

@ozkriff ozkriff merged commit 85dd59c into rust-gamedev:source Nov 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Nov 4, 2020

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants