N15: Sun Prison #344
Merged
N15: Sun Prison #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of rust-gamedev#320 ("Newsletter 15").
Remove trailing spaces and shorten lines to 80 symbols.
Split line 358 to two lines not longer than 80 symbols each.
Collaborator
17cupsofcoffee
left a comment
17cupsofcoffee
left a comment
There was a problem hiding this comment.
Looks good for the most part! Your 2 link isn't rendering properly, though - you can't break the link text and the link ref across 2 lines like that, I don't think.
Contributor
Author
|
@17cupsofcoffee You are right, let me fix it! |
Fix broken link on line 358
Contributor
Author
|
@17cupsofcoffee Fixed now. |
Member
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #320 ("Newsletter 15").