Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N16: Survey reminder #374

Merged
merged 2 commits into from
Dec 4, 2020
Merged

N16: Survey reminder #374

merged 2 commits into from
Dec 4, 2020

Conversation

erlend-sh
Copy link
Member

@erlend-sh erlend-sh commented Dec 1, 2020 •
edited
Loading

Part of #365.

17cupsofcoffee
17cupsofcoffee approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming the newsletter goes out in time :)

@17cupsofcoffee
Copy link
Collaborator

17cupsofcoffee commented Dec 1, 2020 •
edited
Loading

Ah, actually, this is failing the CI - the text needs to be broken onto multiple lines to satisfy the linter, max length 80 chars. Should be good to go after that though.

@erlend-sh erlend-sh changed the title Add survey reminder N16: Survey reminder Dec 1, 2020
ozkriff
ozkriff approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (made a few fmt tweaks for consistency)

@ozkriff ozkriff merged commit 2f745a3 into source Dec 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Dec 4, 2020

Thanks!

@ozkriff ozkriff mentioned this pull request Dec 4, 2020
Closed
@AngelOnFira AngelOnFira deleted the erlend-sh_survey-reminder branch September 4, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

@ozkriff ozkriff ozkriff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-sh @17cupsofcoffee @ozkriff