Skip to content

N16: Release #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 8, 2020
Merged

N16: Release #404

merged 10 commits into from
Dec 8, 2020

Conversation

ozkriff
Copy link
Member

@ozkriff ozkriff commented Dec 8, 2020

Preview (98617a8): https://rust-gamedev-preview.netlify.app/posts/newsletter-016

Everyone is invited to review!

⏲️ Hope to merge this in an hour or so if there're no objections.

Part of #365 ("Newsletter 16")

@ozkriff ozkriff mentioned this pull request Dec 8, 2020
Copy link
Contributor

@djkoloski djkoloski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues. I also noticed that Old Gods wasn't rendering its logo correctly but I wasn't sure if that would be fixed after the merge.

@ozkriff
Copy link
Member Author

ozkriff commented Dec 8, 2020

I also noticed that Old Gods wasn't rendering its logo correctly but I wasn't sure if that would be fixed after the merge.

Hmmm, it looks fine for me 🤔

@djkoloski
Copy link
Contributor

I also noticed that Old Gods wasn't rendering its logo correctly but I wasn't sure if that would be fixed after the merge.

Hmmm, it looks fine for me 🤔

I think it's just an issue with the rich diff viewer. The URL looks right and should point to the right spot once the branch is merged.

@ozkriff
Copy link
Member Author

ozkriff commented Dec 8, 2020

⏲️ merging in ~30 minutes

Copy link
Member

@AlexEne AlexEne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@ozkriff
Copy link
Member Author

ozkriff commented Dec 8, 2020

The release is quite rushed so feel free to review and report issues even after the merge!

@ozkriff ozkriff merged commit 60cbb9e into rust-gamedev:source Dec 8, 2020
@ozkriff ozkriff deleted the n16_release branch December 8, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants