Skip to content

N17: Egui #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2021
Merged

N17: Egui #415

merged 3 commits into from
Jan 8, 2021

Conversation

@emilk
Copy link
Contributor

@emilk emilk commented Jan 4, 2021

Part of #408

@ozkriff ozkriff mentioned this pull request Jan 5, 2021
Closed
17cupsofcoffee
17cupsofcoffee requested changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, just one error on the CI build:

content/posts/newsletter-017/index.md:112:81 MD013/line-length Line length [Expected: 80; Actual: 131]

17cupsofcoffee
17cupsofcoffee approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ozkriff ozkriff merged commit 60750c9 into rust-gamedev:source Jan 8, 2021
@ozkriff
Copy link
Member

ozkriff commented Jan 8, 2021

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emilk @ozkriff @17cupsofcoffee