-
Notifications
You must be signed in to change notification settings - Fork 344
Migrate site to Zola (fixes #7) #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good from as much as I can tell, but I've got no real experience with blog engines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best pr ever :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've posted a few nitpick comments, but overall this is a great PR, thank you so much! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
So, let's merge this PR in a few hours if no one objects? :) |
This is great! But...now the GitHub pages site just shows the README. If you guys want I can setup a Drone CI script for building the site and pushing it to GitHub pages. |
For some reason, the source branch is still master (and not gh-pages) and I can't change it. UPD: https://stackoverflow.com/questions/25559292/github-page-shows-master-branch-not-gh-pages ugh |
So apparently this is working as intended - user/organisation page repos will only let you publish from That leaves us with three options:
I think 3 would be an okay solution (as long as we switch the repo's default branch to (Also, it figures I'd break the site the one night I'm away from my computer... Sorry 😅) |
Option 3 sounds slightly goofy but very simple. Let's do that. |
It's fine because you can set |
My one concern is if the github pages branch is actually "the default branch", and it will change when we change the default branch. I don't know how that works exactly. |
Another option, if the different branch doesn't work, would be to track the source in another repo and have CI push the built result to the organization repo's master branch. |
Ok, I'll try this. |
Aaand done. Set https://rust-gamedev.github.io/ seems to work fine again. |
Excellent, thanks for sorting that out :) |
look upon ye and despair, at the largest PR diff mankind has ever seen
While I was initially not a fan of the idea of migrating the site across to a different generator, a few things have swayed me the other way recently:
So I've gone through and ported the existing theme and content across - as far as I can tell, it looks and behaves identically.
The main user-facing changes are:
/YYYY/MM/DD/slug
URLs, so the posts have been moved to/posts/slug
. All existing posts have aliases defined, so existing links won't break.rss.xml
, notfeed.xml
- again, I've added a redirect.There's a live preview at https://mystifying-keller-336452.netlify.com - please feel free to snoop around for things that are broken :)
The main thing that would still need doing to get this ready to merge would be setting up the CI config - @ozkriff's expertise would be appreciated there 😄