Add paragraph about Arcana game engine #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes lint errors
17cupsofcoffee
requested changes
May 7, 2021
There was a problem hiding this comment.
The content looks good for the most part!
The only major issue is that the GIF is 15mb, which is a long way over our usual limit of 2.5mb. I tried to optimize the GIF via EZGif, but I couldn't get it any lower than 4mb on my end. Could you provide a smaller GIF, or replace it with a screenshot?
|
I'll record shorter video and try to fit 2.5mb |
17cupsofcoffee
approved these changes
May 7, 2021
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope it isn't too late to add note for my upcoming game engine.
part of #589