Skip to content

N23: Release #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2021
Merged

N23: Release #717

merged 5 commits into from
Jul 8, 2021

Conversation

ozkriff
Copy link
Member

@ozkriff ozkriff commented Jul 8, 2021

Preview (052d37a): https://rust-gamedev-preview.netlify.app/news/023

Everyone is invited to review!

⏲️ Hope to merge this ~16:00 UTC today (in ~9 hours from this PR creation) if there're no objections.

Part of #677

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ozkriff
Copy link
Member Author

ozkriff commented Jul 8, 2021

Merging in half an hour. Any more reviews? :)

Copy link
Collaborator

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The only change we'd want is to remove this:

gfx-rs's "contributor-friendly" issues.

Since gfx-rs repo is effectively in maintenance mode now

@ozkriff
Copy link
Member Author

ozkriff commented Jul 8, 2021

@kvark replaced with a link to wgpu-rs help-wanted issues!

@ozkriff ozkriff merged commit e67d28c into rust-gamedev:source Jul 8, 2021
@ozkriff ozkriff deleted the n23_release branch July 8, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants