-
Notifications
You must be signed in to change notification settings - Fork 344
N24: Release #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N24: Release #745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall but here're a few nitpicks/suggestions after a quick glance through
- typo: Sproingers -> Springers
- The "Writing an RPG using rg3d" section could use an image like this or even a preview image for one of the youtube demo videos
- In the "Fish Fight" the 2nd-level sublist of weapons could be collapsed into one line to save space without much harm. Also,
@fedor_games and @erlend_sh
could be turned into links to the corresponding Twitter acoounts.
I think 'sproingers' might be intentional ('sproing' being onomatopoeia for the noise a spring would make), but I could be wrong - @erlend-sh? :) Will make the other two changes when I get a sec. |
Oh no! It seems I forgot to put a direct link to my fancy new website! Could you please change the (currently 404) link to the GGRS tutorial to Thank you! |
Made most of those fixes 👍 I did try collapsing the Fish Fight list, but I found it less readable personally due to the number of items/nested parentheses. I think keeping the list this time is okay since it directly corresponds to what's in the associated image, but in future we maybe wouldn't want to go into quite so much detail on individual items. |
Preview updated: https://sharp-aryabhata-9cc78b.netlify.app/news/024/ |
The section "writing an RPG using rg3d" doesn't have any links to the mentioned video (other than the title link). Might be nice to add something inline? (@mrDIMAS) |
Other than my previous comment, everything else looks good 👍 |
ca55184
to
77b6506
Compare
We have identical Zemeroth screenshots in 2 different sections. I think this needs to be fixed. cc @ozkriff |
@kvark: That was because I didn't have a better screenshot for the Macroquad section - if you think it looks weird, I'll get rid of the duplicate 👍 |
Yeah, I don't think we should have the duplicate here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed through it, all is good outside of the issues noted in the comments
@kvark: Swapped out the duplicate image for a different one, and fixed the WGPU issue text 👍 |
Part of #719
Preview (63f9e3f): https://sharp-aryabhata-9cc78b.netlify.app/news/024/
Aiming to release this in a few hours if there's no objections.