Skip to content

N24: Release #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2021
Merged

N24: Release #745

merged 6 commits into from
Aug 8, 2021

Conversation

17cupsofcoffee
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee commented Aug 8, 2021

Part of #719

Preview (63f9e3f): https://sharp-aryabhata-9cc78b.netlify.app/news/024/

Aiming to release this in a few hours if there's no objections.

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall but here're a few nitpicks/suggestions after a quick glance through

  • typo: Sproingers -> Springers
  • The "Writing an RPG using rg3d" section could use an image like this or even a preview image for one of the youtube demo videos
  • In the "Fish Fight" the 2nd-level sublist of weapons could be collapsed into one line to save space without much harm. Also, @fedor_games and @erlend_sh could be turned into links to the corresponding Twitter acoounts.

@17cupsofcoffee 17cupsofcoffee mentioned this pull request Aug 8, 2021
42 tasks
@17cupsofcoffee
Copy link
Collaborator Author

I think 'sproingers' might be intentional ('sproing' being onomatopoeia for the noise a spring would make), but I could be wrong - @erlend-sh? :)

Will make the other two changes when I get a sec.

@gschup
Copy link
Contributor

gschup commented Aug 8, 2021

Oh no! It seems I forgot to put a direct link to my fancy new website!

Could you please change the (currently 404) link to the GGRS tutorial to [tutorial]: https://gschup.github.io/ggrs/docs/getting-started/quick-start/ ?

Thank you!

@17cupsofcoffee
Copy link
Collaborator Author

Made most of those fixes 👍

I did try collapsing the Fish Fight list, but I found it less readable personally due to the number of items/nested parentheses. I think keeping the list this time is okay since it directly corresponds to what's in the associated image, but in future we maybe wouldn't want to go into quite so much detail on individual items.

@17cupsofcoffee
Copy link
Collaborator Author

@AngelOnFira
Copy link
Member

The section "writing an RPG using rg3d" doesn't have any links to the mentioned video (other than the title link). Might be nice to add something inline? (@mrDIMAS)

image

@AngelOnFira
Copy link
Member

Other than my previous comment, everything else looks good 👍

@17cupsofcoffee
Copy link
Collaborator Author

Linked the video (via the image and the caption) and added an inline link to the tutorial:
image

Will give it another half an hour for any last minute comments and then publish :)

@erlend-sh erlend-sh mentioned this pull request Aug 8, 2021
@kvark
Copy link
Collaborator

kvark commented Aug 8, 2021

We have identical Zemeroth screenshots in 2 different sections. I think this needs to be fixed. cc @ozkriff

@17cupsofcoffee
Copy link
Collaborator Author

@kvark: That was because I didn't have a better screenshot for the Macroquad section - if you think it looks weird, I'll get rid of the duplicate 👍

@kvark
Copy link
Collaborator

kvark commented Aug 8, 2021

Yeah, I don't think we should have the duplicate here.
Also, minor fix would be nice - in "wgpu-rs's "help wanted" issues" the link is correct, but the text should just say "wgpu's "help wanted" issues" (instead of wgpu-rs), since wgpu-rs repo is archived now

Copy link
Collaborator

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through it, all is good outside of the issues noted in the comments

@17cupsofcoffee
Copy link
Collaborator Author

@kvark: Swapped out the duplicate image for a different one, and fixed the WGPU issue text 👍

@17cupsofcoffee 17cupsofcoffee merged commit 6eea510 into source Aug 8, 2021
@17cupsofcoffee 17cupsofcoffee deleted the n24-final branch August 8, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants