Skip to content

N26: good-web-game #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 1, 2021
Merged

N26: good-web-game #786

merged 7 commits into from
Oct 1, 2021

Conversation

PSteinhaus
Copy link
Contributor

Part of #783

@ozkriff ozkriff changed the title added section on good-web-game N26: good-web-game Sep 27, 2021
ozkriff
ozkriff requested changes Sep 28, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the PR overall but it's a little bit too long - ~1.5k visible characters while the style guide requires "<...> The rendered text should be under 1000 characters <...>".

Could you please remove some non-essential information?

@ozkriff
Copy link
Member

ozkriff commented Sep 28, 2021

Cool logo, btw!

@PSteinhaus
Copy link
Contributor Author

Cool logo, btw!

Thanks! :D

Could you please remove some non-essential information?

Will do.

@PSteinhaus
Copy link
Contributor Author

I didn't count the words, but I think it's short enough now, right?
I'm content with it now.

@ozkriff ozkriff mentioned this pull request Oct 1, 2021
Closed
50 tasks
ozkriff
ozkriff approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozkriff ozkriff merged commit a337185 into rust-gamedev:source Oct 1, 2021
@ozkriff
Copy link
Member

ozkriff commented Oct 1, 2021

Merged, thanks for the PR!

@ozkriff ozkriff mentioned this pull request Oct 1, 2021
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PSteinhaus @ozkriff