Skip to content

Newsletter 7: savefile-0.5.0 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2020
Merged

Newsletter 7: savefile-0.5.0 #81

merged 6 commits into from
Mar 4, 2020

Conversation

PatrickHoward
Copy link
Contributor

Here is a short blob I wrote about the savefile crate. I did the version specified in #64 (0.5.0), but the latest stable crate is 0.6.1 (0.6.0 includes breaking features, mentioned in the changelog).

Would that be the version we would want to include? Or would we want to use 0.6.1 instead?

Also any feedback is welcome as this is my first time contributing to a project like this.

@ozkriff
Copy link
Member

ozkriff commented Mar 3, 2020

Would that be the version we would want to include?

v0.6 and v0.6.1 were released in Feb too, so yes, it makes sense to include them too. I just haven't noticed them for some reason.

@PatrickHoward
Copy link
Contributor Author

Sounds good! I’ll make the appropriate adjustments.

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for resolving the comments!

@PatrickHoward
Copy link
Contributor Author

Thanks for looking it over! :)

Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozkriff ozkriff merged commit 6ca59c5 into rust-gamedev:source Mar 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Mar 4, 2020

Merged. Thanks for the PR!

@ozkriff ozkriff mentioned this pull request Mar 4, 2020
58 tasks
@PatrickHoward PatrickHoward deleted the savefile-0.5.0 branch May 5, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants