Skip to content

N27: SPV #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 4, 2021
Merged

N27: SPV #821

merged 9 commits into from
Nov 4, 2021

Conversation

AlbinSjoegren
Copy link
Contributor

Part of #818 ("Newsletter 27")

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good 👍 But this currently doesn't match a couple of the style guidelines:

  • Lines should be 80 characters long maximum (markup/links can go over).
  • The text should be in third person.

On closer inspection, I'm also wondering if this would make more sense in the 'Tooling Updates' section? I thought it was a library when I added it to the list but I now see it's got a GUI :)

@AlbinSjoegren
Copy link
Contributor Author

Will fix that tomorrow, thanks for the feedback.

@17cupsofcoffee
Copy link
Collaborator

No problem 🙂 There's no rush, we usually don't release the newsletter till about a week after we put out the co-ordination issue.

@AlbinSjoegren
Copy link
Contributor Author

AlbinSjoegren commented Nov 3, 2021

For me it can be in either or when it comes to sections but it will be a crate too in the next two weeks so yeah. It is really up to you in the end.

@17cupsofcoffee
Copy link
Collaborator

I think for this month's newsletter it would make more sense to put it under tooling, but can move it to libraries in next month's 👍

@17cupsofcoffee
Copy link
Collaborator

Section looks good now - one more thing, could you add the image to the repo instead of linking to an external URL?

@AlbinSjoegren
Copy link
Contributor Author

Done

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for resolving the comments!

@17cupsofcoffee 17cupsofcoffee merged commit 0a8a570 into rust-gamedev:source Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants