N27 bevy_verlet #832
Merged
N27 bevy_verlet #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17cupsofcoffee
requested changes
Nov 3, 2021
There was a problem hiding this comment.
The content looks good, but the GIF is a bit too big - as a rule of thumb, we prefer to keep them below 2mb to avoid making page loads too slow.
Could you please provide a shorter/more optimized GIF? https://ezgif.com/optimize can be useful for this.
|
@17cupsofcoffee I reduced the gif size to around 2mb but I messed up and forced push over your changes |
17cupsofcoffee
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #818