Skip to content

N30: Graphite #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2022
Merged

N30: Graphite #943

merged 2 commits into from
Feb 9, 2022

Conversation

Keavon
Copy link
Contributor

@Keavon Keavon commented Feb 9, 2022

Part of #912

Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of links that are broken, but I can fix those.

@17cupsofcoffee 17cupsofcoffee merged commit 749395f into rust-gamedev:source Feb 9, 2022
@17cupsofcoffee
Copy link
Collaborator

17cupsofcoffee commented Feb 9, 2022

@Keavon: I just noticed that the image in this PR is broken (I thought it was just GitHub's preview being rubbish like usual, but seeing the same thing locally), could you send me a fixed version? I'll commit it as part of the release PR.

@Keavon
Copy link
Contributor Author

Keavon commented Feb 9, 2022

@17cupsofcoffee Oh no, I wonder why that is! Perhaps the github.dev web editor mangled the image file somehow. Here's the image: https://files.keavon.com/-/FastFineGoldenmantledgroundsquirrel/graphite_alpha.png

@17cupsofcoffee
Copy link
Collaborator

Thank you! Yes, looks like it must have been something weird with GitHub/the upload, as the original file literally only had the PNG header in it, nothing else 😅

I'll get this fixed and re-release the newsletter after work.

@Keavon
Copy link
Contributor Author

Keavon commented Feb 9, 2022

The image showed up fine while I was editing it. I used the split-pane markdown preview and it looked great. So somehow the github.dev editor broke it on commit. Quite strange! I'll look out for that in the future. Thanks for your patience on this!

@AngelOnFira AngelOnFira mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants