Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bytes dependency with byte #35

Merged
merged 5 commits into from
Mar 2, 2021
Merged

Replace bytes dependency with byte #35

merged 5 commits into from
Mar 2, 2021

Conversation

henrikssn
Copy link
Member

@henrikssn henrikssn commented Feb 23, 2021 •
edited by hannobraun
Loading

Fixes #33
Fixes #34

@henrikssn henrikssn changed the title Replace bytes dependency with byte (fixes #33 and #34) Replace bytes dependency with byte Feb 23, 2021
hannobraun
hannobraun suggested changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @henrikssn, this is great! Awesome work!

I did a review and found some problems. See comments for details.

Cargo.toml Outdated Show resolved Hide resolved
src/mac/command.rs Outdated Show resolved Hide resolved
src/mac/frame/mod.rs Outdated Show resolved Hide resolved
src/mac/frame/mod.rs Outdated Show resolved Hide resolved
src/mac/frame/mod.rs Outdated Show resolved Hide resolved
src/mac/frame/mod.rs Outdated Show resolved Hide resolved
@hannobraun
Copy link
Contributor

I lightly edited your PR description to make sure GitHub automatically closes both issues, once this is merged.

henrikssn
henrikssn commented Feb 24, 2021
View reviewed changes
Copy link
Member Author

@henrikssn henrikssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

Cargo.toml Outdated Show resolved Hide resolved
src/mac/command.rs Outdated Show resolved Hide resolved
src/mac/frame/mod.rs Outdated Show resolved Hide resolved
src/mac/frame/mod.rs Outdated Show resolved Hide resolved
src/mac/frame/mod.rs Outdated Show resolved Hide resolved
src/mac/frame/mod.rs Outdated Show resolved Hide resolved
hannobraun
hannobraun suggested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@hannobraun hannobraun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @henrikssn! This is almost ready to merge now.

I made one suggestion regarding documentation. And one of my previous comments isn't resolved yet. Other than that, this looks good to go!

src/mac/frame/mod.rs Outdated Show resolved Hide resolved
@henrikssn
Copy link
Member Author

Thanks for the changes, @henrikssn! This is almost ready to merge now.

I made one suggestion regarding documentation. And one of my previous comments isn't resolved yet. Other than that, this looks good to go!

Those should now be resolved, please take a look.

@hannobraun
Copy link
Contributor

Thank you again, @henrikssn, great work!

@hannobraun hannobraun merged commit 4adb942 into rust-iot:master Mar 2, 2021
@hannobraun
Copy link
Contributor

Released as 0.5.0: https://crates.io/crates/ieee802154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannobraun hannobraun hannobraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest version doesn't compile on arm-thumbv6m targets Latest version depends on alloc via BufMut
2 participants
@henrikssn @hannobraun